feat: Adding terminal autoclass variable for simple and multiple bucket #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snskArora
force-pushed
the
feature/terminal_autoclass
branch
from
7d00f3b to
2d7b4ef
Compare
snskArora
changed the title
bharathkkb
reviewed
Jul 22, 2025
variables.tf
Outdated
| type = map(string) | ||
| default = {} | ||
| validation { | ||
| condition = alltrue([for _, v in var.terminal_autoclass : var.autoclass == false || v == "NEARLINE" || v == "ARCHIVE"]) |
There was a problem hiding this comment.
Since we maintain a min TF compat with tf 1.3 we cannot use cross variable reference in validation rules (i.e checking var.autoclass) which was introduced in 1.9. If there is a validation error if this is set and autoclass is disabled could we perform a check before passing value to terminal_storage_class - something like lookup(var.autoclass..) ? lookup(var.terminal_autoclass...) : null
There was a problem hiding this comment.
Hi @bharathkkb
The lookup during the assignment would be of no use as this is specifically to root out the wrong input (basically converting the string to an enum). Since it has to be compatible with v1.3 I will remove the autoclass check from the validation block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would resolve #405